fix: improve moving object store items to trashbin #48224
Merged
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
yemkareems and
provokateurin
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
object-store-trash-move
branch
from
95427ec
to
938a79a
Compare
provokateurin
approved these changes
Sep 19, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
object-store-trash-move
branch
from
938a79a
to
42ea824
Compare
|
/backport to stable30 |
come-nc
approved these changes
Sep 20, 2024
2 tasks
|
Added to #48488 for the 29 backport |
|
Added to #48213 for the 28 backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With various changes to how objectstore
moveFromStorageworks since this code was last touched. The following version should be "more correct".